[Top] [All Lists]

Re: [PATCH] use generic posix ACL code, enable ACL caching

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: [PATCH] use generic posix ACL code, enable ACL caching
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 25 Jul 2008 06:32:30 +0200
Cc: xfs@xxxxxxxxxxx
In-reply-to: <ncctzeetwnl.fsf@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20080614160127.GA15404@xxxxxx> <20080723201940.GA7908@xxxxxx> <ncctzeetwnl.fsf@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Fri, Jul 25, 2008 at 02:28:30PM +1000, Niv Sardi wrote:
> I like the patch, and don't think we need to wait for the trans aware
> attr code to get it in (it's not attomic now and nobody cares as you
> pointed out) that said, it's pretty big, and I'm did not review it
> carefully enough, and'd be *much* more comfortable if someone that knows
> the code more (like tes) could have a look at it before putting it in.

Tim had started looking at it a while ago, and for a patch of this
complexity I'm more than happy to wait a long time for a throughout review.

This particular non-atomicy doesn't exist with the current code, btw
because we don't do any adjustments of the ACL entries on chmod time.

In fact we might just drop this call because XFS doesn't require the
ACL to be minimal and the other filesystems only do it for compatiblity
with future ACE entry types that will most likely never exist.  That's
why I'd like to wait for some comments from Tim - I just make sure
the latest version of the patch always stays posted for anyone to look
at it.

<Prev in Thread] Current Thread [Next in Thread>