xfs
[Top] [All Lists]

Re: [PATCH] use generic posix ACL code, enable ACL caching

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] use generic posix ACL code, enable ACL caching
From: Niv Sardi <xaiki@xxxxxxx>
Date: Fri, 25 Jul 2008 14:28:30 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080723201940.GA7908@xxxxxx> (Christoph Hellwig's message of "Wed, 23 Jul 2008 22:19:40 +0200")
References: <20080614160127.GA15404@xxxxxx> <20080723201940.GA7908@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (x86_64-pc-linux-gnu)
Christoph Hellwig <hch@xxxxxx> writes:

> On Sat, Jun 14, 2008 at 06:01:27PM +0200, Christoph Hellwig wrote:
>> Switch XFS to use the generic ACL code and enable caching the ACL values
>> in the XFS inode.
>> 
>> Compared to the last post various bugs have been fixed and a locking
>> strategy has been designed and implemented.  This now passes XFSQA.
>> 
>> You'll need my various attr-related patches applies before this one.
>
> With various recent changes going in it needed another rediff.  I also
> moved the xfs_acl_chmod call into xfs_setattr from xfs_vn_setattr
> because we would miss it for updates from dmapi.  While doing this
> I found out that xfs_acl_chmod is non-atomic vs the setattr which is
> probably a bad thing, but also done that way in all other filesystems.
>
> Maybe we want to delay this patch until Niv's infrastructure to
> piggy-back an attr_set ontop of an existing transaction is done so
> that this issue could be solved.

I like the patch, and don't think we need to wait for the trans aware
attr code to get it in (it's not attomic now and nobody cares as you
pointed out) that said, it's pretty big, and I'm did not review it
carefully enough, and'd be *much* more comfortable if someone that knows
the code more (like tes) could have a look at it before putting it in.

Cheers,
-- 
Niv Sardi


<Prev in Thread] Current Thread [Next in Thread>