[Top] [All Lists]

Re: [PATCH 05/15] make btree root in inode support generic

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 05/15] make btree root in inode support generic
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 25 Jul 2008 09:28:27 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080723200848.GF7401@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20080723200848.GF7401@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jul 23, 2008 at 10:08:48PM +0200, Christoph Hellwig wrote:
> The bmap btree is rooted in the inode and not in a single disk block.  Make
> the support for this feature more generic by:
>  (a) adding a btree flag to check for instead of the XFS_BTNUM_BMAP type
>  (b) add a get_root_from_inode btree operation to get a btree block from
>      the inode, with the implementation details left to the individual btree.
> Also clean up xfs_btree_get_block, which is the place these two features
> are used.
> The XFS_BTREE_ROOT_IN_INODE is based upon a patch from Dave Chinner.

Looks good.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>