| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/15] split up xfs_btree_init_cursor |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 25 Jul 2008 09:25:37 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20080723200835.GD7401@xxxxxx> |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
| References: | <20080723200835.GD7401@xxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Jul 23, 2008 at 10:08:35PM +0200, Christoph Hellwig wrote: > xfs_btree_init_cursor contains close to little shared code for the different > btrees and will get even more non-common code in the future. Split it up > into one routine per btree type. > > Because xfs_btree_dup_cursor needs to call the init routine for a generic > btree cursor add a new btree operation vector that contains a dup_cursor > method that initializes a new cursor based on an existing one. > > The btree operations vector is based on an idea and code from Dave Chinner > and will be used for more operations later on. Looks ok to me. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 01/15] small cleanups in xfs_btree.c, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 04/15] add generic btree types, Dave Chinner |
| Previous by Thread: | [PATCH 03/15] split up xfs_btree_init_cursor, Christoph Hellwig |
| Next by Thread: | [PATCH 04/15] add generic btree types, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |