On Thu, 24 Jul 2008 13:59:13 -0400 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Fri, Jul 25, 2008 at 01:17:11AM +1000, Nick Piggin wrote:
> > Hi, I have some questions about your patch in -mm
> > vfs-pagecache-usage-optimization-onpagesize=blocksize-environment.patch
> > I have no particular problem with something like this, but leaving the
> > implementation details aside for the moment, can we discuss the
> > justification for this?
> > Are there significant numbers of people using block size < page size in
> > situations where performance is important and significantly improved by
> > this patch? Can you give any performance numbers to illustrate perhaps?
> With XFS lots of people use 4k blocksize filesystems on ia64 systems
> with 16k pages, so an optimization like this would be useful.
As Nick says, we really should have some measurement results which
confirm this theory. Maybe we did do some but they didn't find theor
way into the changelog.
I've put the patch on hold until this confirmation data is available.
> But as mentioned in one of your previous comments I'd rather prefer
> a readpage interface chaneg to deal with this.