Re: [PATCH] Introduce xfs_bmap_add_attrfork_trans.

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> +error0:
> +     xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES|XFS_TRANS_ABORT);
> +     ASSERT(ip->i_df.if_ext_max ==
> +            XFS_IFORK_DSIZE(ip) / (uint)sizeof(xfs_bmbt_rec_t));
> +     return error;

I think the transaction cancelling should be done by the caller.  The
callers will surely have cases where they have to cancel the transaction
already, and it's also more symmetric.

> +     VN_HOLD(XFS_ITOV(ip));

Please just use

        IHOLD(ip);

instead of the above construct.

Otherwise this looks fine and like another candidate to commit already.