[Top] [All Lists]

Re: [PATCH] Export xfs_attr_set_int_trans

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: [PATCH] Export xfs_attr_set_int_trans
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Jul 2008 03:46:04 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <nccljzuh2ps.fsf@xxxxxxxxxxxxxxxxxxxxxxx>
References: <1215675545-2707-5-git-send-email-xaiki@xxxxxxx> <1215754695-6958-1-git-send-email-xaiki@xxxxxxx> <20080722044337.GA10290@xxxxxxxxxxxxx> <nccljzuh2ps.fsf@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jul 22, 2008 at 04:06:55PM +1000, Niv Sardi wrote:
> Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
> > On Fri, Jul 11, 2008 at 03:38:14PM +1000, Niv Sardi wrote:
> >> make xfs_attr_set_int_trans non static so we can use it outside of 
> >> xfs_attr.c
> >> (Needed to use it in vnodeops.c, for create+EA)
> >
> > Any reason this is not merged into the previous patch?
> you =) you didn't like my attr_* function to be exported, so I splitted
> the export out from now on. that's about it.

Heh, sorry.  The general rule is exporting it is fine if one of the
next patches uses it.  That wasn't obvious when you posted the first
patches, so I asked for it to be static for now.

<Prev in Thread] Current Thread [Next in Thread>