xfs
[Top] [All Lists]

Re: [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes

To: Mark Goodwin <markgw@xxxxxxx>
Subject: Re: [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 23 Jul 2008 14:27:21 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4886ADB6.5060109@xxxxxxx>
Mail-followup-to: Mark Goodwin <markgw@xxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1216556394-17529-1-git-send-email-david@xxxxxxxxxxxxx> <1216556394-17529-3-git-send-email-david@xxxxxxxxxxxxx> <20080722042829.GB27123@xxxxxxxxxxxxx> <20080722053019.GI6761@disturbed> <20080722072733.GA15376@xxxxxxxxxxxxx> <20080723000548.GG5947@disturbed> <488692FB.1010101@xxxxxxx> <4886A9A3.8090805@xxxxxxxxxxx> <4886ADB6.5060109@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jul 23, 2008 at 02:04:06PM +1000, Mark Goodwin wrote:
>
> Eric Sandeen wrote:
>> Mark Goodwin wrote:
>> For general algorithm improvements... how do you write a new QA test for
>> "Use the inode tree for finding dirty inodes?"
>
> Case by case basis I guess. e.g. write a test that exercises or stresses
> the changed algorithm or functionality, especially corner cases
> (low space, full AGs, mem pressure, whatever).

Most of these corner cases are already covered by XFSQA.

> Performance regression testing
> is trickier - need access to suitable h/w and the historical data; so it's
> probably best run on dedicated h/w every night against the dev tree.

Performance regressions are something that generally are only
detected some time after the commit occurs - usually when it gets to
the wider community. Once again, it's an argument for further
distributing the QA load by committing quickly.

Indeed, in the case of regressions caused by commmunity
contributions, I think a bugzilla bug needs to be raised to
track it properly....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>