xfs
[Top] [All Lists]

TAKE 984429 - Do not access buffers after dropping reference count

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 984429 - Do not access buffers after dropping reference count
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Tue, 22 Jul 2008 17:58:13 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Do not access buffers after dropping reference count

We should not access a buffer after dropping it's reference count otherwise
we could race with another thread that releases the final reference count
and frees the buffer causing us to access potentially unmapped memory.
The bug this change fixes only occured on DEBUG XFS since the offending
code was in an ASSERT.

Date:  Tue Jul 22 17:57:07 AEST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-tot
Inspected by:  david@xxxxxxxxxxxxx
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31715a
fs/xfs/linux-2.6/xfs_buf.c - 1.258 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.c.diff?r1=text&tr1=1.258&r2=text&tr2=1.257&f=h
        - Do not access buffers after dropping reference count




<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 984429 - Do not access buffers after dropping reference count, Lachlan McIlroy <=