| To: | Lachlan McIlroy <lachlan@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Do not access buffers after dropping reference count |
| From: | Lachlan McIlroy <lachlan@xxxxxxx> |
| Date: | Tue, 22 Jul 2008 12:55:52 +1000 |
| In-reply-to: | <20080722022404.GH6761@disturbed> |
| References: | <4885430D.7000506@xxxxxxx> <20080722022404.GH6761@disturbed> |
| Reply-to: | lachlan@xxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.14 (X11/20080421) |
Dave Chinner wrote: On Tue, Jul 22, 2008 at 12:16:45PM +1000, Lachlan McIlroy wrote:We should not access a buffer after dropping it's reference count otherwise we could race with another thread that releases the final reference count and frees the buffer causing us to access potentially unmapped memory.Looks OK. The commit message should point out this is a problem only for DEBUG kernels, though. Okay, will do. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Do not access buffers after dropping reference count, Dave Chinner |
|---|---|
| Next by Date: | Re: xfsrestore over ssh?, Richard Hartmann |
| Previous by Thread: | Re: [PATCH] Do not access buffers after dropping reference count, Dave Chinner |
| Next by Thread: | [PATCH] Prevent log tail pushing from blocking on buffer locks, Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |