xfs
[Top] [All Lists]

Re: [PATCH] XFS: remove i_gen from incore inode

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] XFS: remove i_gen from incore inode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Jul 2008 07:52:28 -0400
In-reply-to: <20080721110814.GC6761@disturbed>
References: <1216558002-838-1-git-send-email-david@xxxxxxxxxxxxx> <20080721075449.GB6692@xxxxxxxxxxxxx> <20080721110814.GC6761@disturbed>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jul 21, 2008 at 09:08:14PM +1000, Dave Chinner wrote:
> On Mon, Jul 21, 2008 at 03:54:49AM -0400, Christoph Hellwig wrote:
> > On Sun, Jul 20, 2008 at 10:46:42PM +1000, Dave Chinner wrote:
> > > i_gen is incremented in directory operations when the
> > > directory is changed. It is never read or otherwise used
> > > so it should be removed to help reduce the size of the
> > > struct xfs_inode.
> > 
> > It also removes a xfs_trans_log_inode in xfs_remove, which looks
> > fine to me from a quick glance, but this should be verified and
> > documented.
> 
> If you note in the very next if/else statement the directory inode
> gets logged - either by dropping the link or directly. IOWs, we
> were logging the directory inode twice with the same value
> (XFS_ILOG_CORE). So I don't think there??s any problem here.

Indeed. The patch looks good but a little description like the one above
in the commit message would be nice.


<Prev in Thread] Current Thread [Next in Thread>