Re: [PATCH] XFS: remove i_gen from incore inode

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Mon, Jul 21, 2008 at 03:54:49AM -0400, Christoph Hellwig wrote:
> On Sun, Jul 20, 2008 at 10:46:42PM +1000, Dave Chinner wrote:
> > i_gen is incremented in directory operations when the
> > directory is changed. It is never read or otherwise used
> > so it should be removed to help reduce the size of the
> > struct xfs_inode.
> 
> It also removes a xfs_trans_log_inode in xfs_remove, which looks
> fine to me from a quick glance, but this should be verified and
> documented.

If you note in the very next if/else statement the directory inode
gets logged - either by dropping the link or directly. IOWs, we
were logging the directory inode twice with the same value
(XFS_ILOG_CORE). So I don't think thereśs any problem here.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx