Re: [PATCH 0/3] XFS: sanitise VFS inode extraction

xfs

Re: [PATCH 0/3] XFS: sanitise VFS inode extraction

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 0/3] XFS: sanitise VFS inode extraction
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 21 Jul 2008 04:01:31 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1216557828-29056-1-git-send-email-david@xxxxxxxxxxxxx>
References:	<1216557828-29056-1-git-send-email-david@xxxxxxxxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.18 (2008-05-17)

On Sun, Jul 20, 2008 at 10:43:45PM +1000, Dave Chinner wrote:
> Getting the VFS inode from the XFS inode is done in a variety of
> ways right now - direct deference or one of two XFS_ITOV macros.
> This should be consi??tent throughout the code - this patch
> series does that in a way that is consistent with the opposite
> XFS_I() conversion. We now use VFS_I() to extract the VFS inode
> from the XFS inode.

All three patches looks good to me, but please kill the vn_to_inode
useage in VFS_I - vn_to_inode and inode_to_vn are not needed anymore
at all nowdays and will go away completely real soon.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/3] XFS: sanitise VFS inode extraction, Dave Chinner [PATCH 2/3] XFS: kill shouty XFS_ITOV_NULL macro, Dave Chinner [PATCH 3/3] XFS: Kill shouty XFS_ITOV() macro, Dave Chinner [PATCH 1/3] XFS: Avoid directly referencing the VFS inode., Dave Chinner Re: [PATCH 0/3] XFS: sanitise VFS inode extraction, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 1/4] XFS: Remove xfs_iflush_all and clean up xfs_finish_reclaim_all(), Christoph Hellwig
Next by Date:	Re: XFS internal error xfs_btree_check_lblock, Richard Ems
Previous by Thread:	[PATCH 1/3] XFS: Avoid directly referencing the VFS inode., Dave Chinner
Next by Thread:	[PATCH] XFS: remove i_gen from incore inode, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]