xfs
[Top] [All Lists]

Re: [PATCH] XFS: remove i_gen from incore inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: remove i_gen from incore inode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Jul 2008 03:54:49 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1216558002-838-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1216558002-838-1-git-send-email-david@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Jul 20, 2008 at 10:46:42PM +1000, Dave Chinner wrote:
> i_gen is incremented in directory operations when the
> directory is changed. It is never read or otherwise used
> so it should be removed to help reduce the size of the
> struct xfs_inode.

It also removes a xfs_trans_log_inode in xfs_remove, which looks
fine to me from a quick glance, but this should be verified and
documented.

Otherwise looks good.


<Prev in Thread] Current Thread [Next in Thread>