[Top] [All Lists]

Re: [PATCH 3/3] Add timeout feature

To: Takashi Sato <t-sato@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] Add timeout feature
From: jim owens <jowens@xxxxxx>
Date: Mon, 14 Jul 2008 10:04:30 -0400
Cc: mtk.manpages@xxxxxxxxxxxxxx, axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, pavel@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, Miklos Szeredi <miklos@xxxxxxxxxx>, Arjan van de Ven <arjan@xxxxxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
In-reply-to: <88E7CDF01964465CB9F33DE11298271D@xxxxxxxxxxxxxxxx>
References: <20080709005254.GQ11558@disturbed> <20080709010922.GE9957@xxxxxxx> <E1KGSvZ-0006dB-53@xxxxxxxxxxxxxxxxxxx> <20080709061621.GA5260@xxxxxxxxxxxxx> <E1KGT4q-0006fD-Jb@xxxxxxxxxxxxxxxxxxx> <20080708234120.5072111f@xxxxxxxxxxxxx> <E1KGTTm-0006ke-Jh@xxxxxxxxxxxxxxxxxxx> <20080708235502.1c52a586@xxxxxxxxxxxxx> <20080709071346.GS11558@disturbed> <20080709110900.GI9957@xxxxxxx> <20080709114958.GV11558@disturbed> <4874C3E8.20804@xxxxxx> <88E7CDF01964465CB9F33DE11298271D@xxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.7.13) Gecko/20060421
Takashi Sato wrote:

What is the difference between the timeout and AUTO-THAW?
When the kernel detects a deadlock, does it occur to solve it?

TIMEOUT is a user-specified limit for the freeze.  It is
not a deadlock preventer or deadlock breaker.  The reason
it exists is:

   - middle of the night (low but not zero users)
   - cron triggers freeze and hardware snapshot
   - san is overloaded by tape copy traffic so
     hardware will take 2 hours to ack snapshot done
   - user "company president" tries to create a report
     needed for an AM meeting with bankers
   - with so few users, system will just patiently
     wait for hardware to finish
   - after 10 minutes "company president" pages
     admin, admin's boss, and "IT vice president"
     in a real unhappy mood

AUTO-THAW is simply a name for the effect of all deadlock
preventer and deadlock breaker code that the kernel has
in the freeze implementation paths... if that code would
unfreeze the filesystem.  We also implemented deadlock
preventer code that does not thaw the freeze.

None of the AUTO-THAW code is there to stop a stupid
userspace program caller of freeze.  It handles things
like "a system in our cluster is going down so we
must have this filesystem unfrozen or the whole
cluster will crash".   In places where there could be
a kernel deadlock we made it "lock-only-if-non-blocking"
and if we could not wait to retry later, the failure
to lock would trigger an immediate unfreeze.

Deadlock prevention needs code in critical paths in more
than just filesystems.  Sometimes this is as simple as
an "I can't wait on freeze" flag added to a vm-filesystem

Timers just don't work for keeping the kernel alive
because they don't trigger on resource exhaustion.


<Prev in Thread] Current Thread [Next in Thread>