xfs
[Top] [All Lists]

Re: xfs bug in 2.6.26-rc9

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: xfs bug in 2.6.26-rc9
From: Sebastian Siewior <lkml@xxxxxxxxxxxxxxxx>
Date: Sat, 12 Jul 2008 07:06:12 +0200
Cc: Mikael Abrahamsson <swmike@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20080711232201.GG11558@disturbed>
References: <alpine.DEB.1.10.0807110939520.30192@xxxxxxxxxxxxxxxx> <20080711084248.GU29319@disturbed> <20080711190209.GA7401@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080711232201.GG11558@disturbed>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.16 (2007-06-09)
* Dave Chinner | 2008-07-12 09:22:01 [+1000]:

>I effectively quoted from it:
>
>config XFS_DEBUG
>        bool "XFS Debugging support (EXPERIMENTAL)"
>        depends on XFS_FS && EXPERIMENTAL
>        help
>          Say Y here to get an XFS build with many debugging features,
>          including ASSERT checks, function wrappers around macros,
>          and extra sanity-checking functions in various code paths.
>
>          Note that the resulting code will be HUGE and SLOW, and probably
>          not useful unless you are debugging a particular problem.
>
>          Say N unless you are an XFS developer, or you play one on TV.
>
>> Debug mode is usually
>> noisy, little slower and mostly usefull just to the developers but *I*
>> would not expect to BUG() in the non-fatal case.
>
>What do you expect debug code to do? Asserts are designed to
>drop the machine into a debugger when they fail so the problem can
>be, well, debugged.
Sorry, I haven't read this. Userspace assert() results in abort() so it
sane to bug() in kernel.

>Dave.
Sebastian


<Prev in Thread] Current Thread [Next in Thread>