[Top] [All Lists]

Re: [PATCH] Fix reference counting race on log buffers

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] Fix reference counting race on log buffers
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2008 17:19:53 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4876EED7.8060004@xxxxxxx>
Mail-followup-to: Timothy Shimmin <tes@xxxxxxx>, xfs@xxxxxxxxxxx
References: <1215752481-6862-1-git-send-email-david@xxxxxxxxxxxxx> <4876EED7.8060004@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Fri, Jul 11, 2008 at 03:25:43PM +1000, Timothy Shimmin wrote:
> Dave,
> Yeah, looks good. Thanks.

Thanks, Tim - I'll add the right tags and send it to Linus.

> (My personal preference is for reversing if/else than using !
>  as it is easier to read but whatever :)

It looked funny with one line in the upper branch, and I added
the comment inside the if() because it wasn't obvious from the
code (either way) which branch was the 'only ref' branch....

> But will need Eric's result before checking it in.

Seems like it's working fine, and i've got a coupl eof runs
through xfsqa now, so it should be good to go.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>