[Top] [All Lists]

Re: [PATCH] Give a transaction to xfs_attr_set_int

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: [PATCH] Give a transaction to xfs_attr_set_int
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2008 01:59:56 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <878ww9asag.fsf@xxxxxxxxxxxxx>
References: <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1215675545-2707-1-git-send-email-xaiki@xxxxxxx> <1215675545-2707-2-git-send-email-xaiki@xxxxxxx> <1215675545-2707-3-git-send-email-xaiki@xxxxxxx> <1215675545-2707-4-git-send-email-xaiki@xxxxxxx> <1215675545-2707-5-git-send-email-xaiki@xxxxxxx> <878ww9asag.fsf@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Jul 11, 2008 at 03:44:39PM +1000, Niv Sardi wrote:
> Ok, so following are 2 patches that will, export xfs_attr_set_int_trans,
> and use it where we would use it in Parent Pointers (and V4ACL to what I
> understand).
> This exposes the bug that I refered to before, and that I'm not sure I
> understand fully.

Actually plain Posix ACLs and selinux need it too to guarantee atomicy.
See xfs_init_security() and whatever _ACL_INHERIT expans to in
fs/xfs/linux-2.6/xfs_iops.c.  These might be good testcases to get
started with this work.

<Prev in Thread] Current Thread [Next in Thread>