xfs
[Top] [All Lists]

Re: [patch] xfsqa 078 - use rmdir to remove directories

To: xfs@xxxxxxxxxxx
Subject: Re: [patch] xfsqa 078 - use rmdir to remove directories
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2008 08:42:38 +1000
In-reply-to: <20080522061120.GP173056135@xxxxxxx>
Mail-followup-to: xfs@xxxxxxxxxxx
References: <20080522061120.GP173056135@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
ping?

On Thu, May 22, 2008 at 04:11:20PM +1000, David Chinner wrote:
> 
> If test 078 fails and you try to run it again immediately, it
> will execute a 'rm -f' on a directory which will fail. This should
> be a rmdir....
> 
> Signed-off-by: Dave Chinner <dgc@xxxxxxx>
> ---
>  xfstests/078 |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: xfs-cmds/xfstests/078
> ===================================================================
> --- xfs-cmds.orig/xfstests/078        2008-03-20 09:10:02.000000000 +1100
> +++ xfs-cmds/xfstests/078     2008-05-15 23:21:58.192413673 +1000
> @@ -50,8 +50,8 @@ _filter_io()
>  # real QA test starts here
>  
>  echo "*** create loop mount point"
> -rm -f $LOOP_MNT 2>/dev/null
> -mkdir $LOOP_MNT || _fail "cannot create loopback mount point"
> +rmdir $LOOP_MNT 2>/dev/null
> +mkdir -p $LOOP_MNT || _fail "cannot create loopback mount point"
>  
>  _grow_loop()
>  {
> 
> 

-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch] xfsqa 078 - use rmdir to remove directories, Dave Chinner <=