xfs
[Top] [All Lists]

Re: [PATCH 3/3] Add timeout feature

To: Miklos Szeredi <miklos@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] Add timeout feature
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 9 Jul 2008 21:15:26 +1000
Cc: arjan@xxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, tytso@xxxxxxx, pavel@xxxxxxx, t-sato@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, axboe@xxxxxxxxx, mtk.manpages@xxxxxxxxxxxxxx
In-reply-to: <E1KGUlR-0006zH-FT@xxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Miklos Szeredi <miklos@xxxxxxxxxx>, arjan@xxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, tytso@xxxxxxx, pavel@xxxxxxx, t-sato@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, axboe@xxxxxxxxx, mtk.manpages@xxxxxxxxxxxxxx
References: <20080709005254.GQ11558@disturbed> <20080709010922.GE9957@xxxxxxx> <E1KGSvZ-0006dB-53@xxxxxxxxxxxxxxxxxxx> <20080709061621.GA5260@xxxxxxxxxxxxx> <E1KGT4q-0006fD-Jb@xxxxxxxxxxxxxxxxxxx> <20080708234120.5072111f@xxxxxxxxxxxxx> <20080709065950.GR11558@disturbed> <E1KGTrq-0006qj-1u@xxxxxxxxxxxxxxxxxxx> <20080709073358.GT11558@disturbed> <E1KGUlR-0006zH-FT@xxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Wed, Jul 09, 2008 at 10:11:01AM +0200, Miklos Szeredi wrote:
> On Wed, 9 Jul 2008, Dave Chinner wrote:
> > On Wed, Jul 09, 2008 at 09:13:34AM +0200, Miklos Szeredi wrote:
> > > On Wed, 9 Jul 2008, Dave Chinner wrote:
> > > > The argument against Miklos' version is that there may be multiple
> > > > commands to execute while the fs is frozen.
> > > 
> > > Which is what a shell is for ;)
> > 
> > Yeah, weĺl, with your method I ca't tell a user to:
> > 
> >     # xfs_freeze -f /mntpt
> >     # xfs_db -r -c 'sb 0' -c 'p rootino' /dev/foo
> >     128
> >     # xfs_db -r -c 'ino 128' -c 'p core.format' /dev/foo
> >     core.format = 2 (extents)
> >     # xfs_db .....
> >     .....
> >     # xfs_freeze -u /mntpt
> > 
> > i.e. using the freeze to force all metadata to disk and
> > prevent it from changing while doing interactive debugging
> > of some problem.
> 
>       # run_freeze /mntpt /bin/bash
>       # ...
>       # ^D
> 
> It's the same, no?

For that case, yeah. But it's a horrible hack - if that's the
best we can come up with for this freeze/unfreeze then we've
already lost.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>