[Top] [All Lists]

Re: [PATCH 3/3] Add timeout feature

To: arjan@xxxxxxxxxxxxx
Subject: Re: [PATCH 3/3] Add timeout feature
From: Miklos Szeredi <miklos@xxxxxxxxxx>
Date: Wed, 09 Jul 2008 09:08:07 +0200
Cc: miklos@xxxxxxxxxx, miklos@xxxxxxxxxx, hch@xxxxxxxxxxxxx, tytso@xxxxxxx, pavel@xxxxxxx, t-sato@xxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, axboe@xxxxxxxxx, mtk.manpages@xxxxxxxxxxxxxx
In-reply-to: <20080708235502.1c52a586@xxxxxxxxxxxxx> (message from Arjan van de Ven on Tue, 8 Jul 2008 23:55:02 -0700)
References: <20080630212450t-sato@xxxxxxxxxxxxxxx> <20080701081026.GB16691@xxxxxxxxxxxxx> <20080707110730.GG5643@xxxxxx> <20080708231026.GP11558@disturbed> <20080708232031.GE18195@xxxxxxxxxx> <20080709005254.GQ11558@disturbed> <20080709010922.GE9957@xxxxxxx> <E1KGSvZ-0006dB-53@xxxxxxxxxxxxxxxxxxx> <20080709061621.GA5260@xxxxxxxxxxxxx> <E1KGT4q-0006fD-Jb@xxxxxxxxxxxxxxxxxxx> <20080708234120.5072111f@xxxxxxxxxxxxx> <E1KGTTm-0006ke-Jh@xxxxxxxxxxxxxxxxxxx> <20080708235502.1c52a586@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
On Tue, 8 Jul 2008, Arjan van de Ven wrote:
> I tihnk the idea there is
> freeze . do the snapshot op . unfreeze . make backup of snapshot

Ah, so then my proposal would become

  run_frozen mountpoint do-snapshot

and if they are afraid of deadlocks they can just implement the
timeout in userspace:

  run_frozen -t timeout mountpoint do-snapshot

'run_frozen' can be a trivial 30 line app, that can be guaranteed not
to deadlock.

> one can argue about the need of doing the first 3 steps via a userland
> loop; it sure sounds like one needs to be really careful to not do any
> writes to the fs from the app that does snapshots (and that includes
> doing any syscalls in the kernel that allocate memory.. just because
> that already could cause unrelated data to be written from inside the
> app. Not fun.)

Userland always has to be careful when messing with raw devices.  That
alone is not a reason to put the snapshotting facility in kernel IMO.


<Prev in Thread] Current Thread [Next in Thread>