xfs
[Top] [All Lists]

Re: [PATCH] convert xfs to use ERR_CAST

To: xfs mailing list <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] convert xfs to use ERR_CAST
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 07 Jul 2008 21:55:33 -0500
In-reply-to: <480FA737.5030001@xxxxxxxxxxx>
References: <480FA737.5030001@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Eric Sandeen wrote:
> Looks like somehow xfs got missed in the conversion that
> took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
> "Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) 
> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---

ping.

This one's really, really, really easy :)

-Eric

> ndex: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_export.c
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
> @@ -167,7 +167,7 @@ xfs_fs_fh_to_dentry(struct super_block *
>       if (!inode)
>               return NULL;
>       if (IS_ERR(inode))
> -             return ERR_PTR(PTR_ERR(inode));
> +             return ERR_CAST(inode);
>       result = d_alloc_anon(inode);
>       if (!result) {
>               iput(inode);
> @@ -198,7 +198,7 @@ xfs_fs_fh_to_parent(struct super_block *
>       if (!inode)
>               return NULL;
>       if (IS_ERR(inode))
> -             return ERR_PTR(PTR_ERR(inode));
> +             return ERR_CAST(inode);
>       result = d_alloc_anon(inode);
>       if (!result) {
>               iput(inode);
> 
> 
> 


<Prev in Thread] Current Thread [Next in Thread>