xfs
[Top] [All Lists]

Re: [PATCH] Introduce xfs_trans_bmap_add_attrfork.

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] Introduce xfs_trans_bmap_add_attrfork.
From: Niv Sardi <xaiki@xxxxxxx>
Date: Thu, 03 Jul 2008 09:39:52 +1000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <486B3B76.8020303@xxxxxxx> (Timothy Shimmin's message of "Wed, 02 Jul 2008 18:25:26 +1000")
References: <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1214196150-5427-2-git-send-email-xaiki@xxxxxxx> <1214196150-5427-3-git-send-email-xaiki@xxxxxxx> <1214196150-5427-4-git-send-email-xaiki@xxxxxxx> <20080626092856.GA27069@xxxxxxxxxxxxx> <nccy74r1oba.fsf@xxxxxxx> <486B3B76.8020303@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (i486-pc-linux-gnu)
Timothy Shimmin <tes@xxxxxxx> writes:
[...]
>> +    if (error)
>> +            goto error1;
>> +
>> +    if (XFS_IFORK_Q(ip))
>> +            goto error1;
>> +
>> +    ASSERT(ip->i_d.di_anextents == 0);
>> +    VN_HOLD(XFS_ITOV(ip));
>> +    xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
>> +    xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
>> +
>> +    error = xfs_trans_bmap_add_attrfork(NULL, ip, size, rsvd);
>> +    if (error)
>> +            return error;
>> +    return xfs_trans_commit(tp, XFS_TRANS_PERM_LOG_RES);
>
> I was kind of expecting the transaction, &tp, to be passed into
> xfs_trans_bmap_add_attrfork().
> (And then xfs_trans_bmap_add_attrfork() which calls
> xfs_bmap_finish() which calls xfs_trans_dup() and so from that
> point on we would then have to update tp if we were to use it.)
>
> So how come we pass in NULL?
> I'm tired so I'm probably missing something obvious.

No you're right, it took me a while to remember you're working out of
git. I haven't really re-read it properly yet but thanks for this one.

Cheers,
-- 
Niv Sardi


<Prev in Thread] Current Thread [Next in Thread>