Re: [PATCH] Introduce xfs_trans_bmap_add_attrfork.

[Niv Sardi <xaiki@xxxxxxx>]

Timothy Shimmin <tes@xxxxxxx> writes:
[...]
>> +    if (error)
>> +            goto error1;
>> +
>> +    if (XFS_IFORK_Q(ip))
>> +            goto error1;
>> +
>> +    ASSERT(ip->i_d.di_anextents == 0);
>> +    VN_HOLD(XFS_ITOV(ip));
>> +    xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
>> +    xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
>> +
>> +    error = xfs_trans_bmap_add_attrfork(NULL, ip, size, rsvd);
>> +    if (error)
>> +            return error;
>> +    return xfs_trans_commit(tp, XFS_TRANS_PERM_LOG_RES);
>
> I was kind of expecting the transaction, &tp, to be passed into
> xfs_trans_bmap_add_attrfork().
> (And then xfs_trans_bmap_add_attrfork() which calls
> xfs_bmap_finish() which calls xfs_trans_dup() and so from that
> point on we would then have to update tp if we were to use it.)
>
> So how come we pass in NULL?
> I'm tired so I'm probably missing something obvious.

No you're right, it took me a while to remember you're working out of
git. I haven't really re-read it properly yet but thanks for this one.

Cheers,
-- 
Niv Sardi