xfs
[Top] [All Lists]

Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll
From: Timothy Shimmin <tes@xxxxxxx>
Date: Wed, 02 Jul 2008 17:14:18 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1214196150-5427-3-git-send-email-xaiki@xxxxxxx>
References: <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1214196150-5427-2-git-send-email-xaiki@xxxxxxx> <1214196150-5427-3-git-send-email-xaiki@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Niv Sardi wrote:
> Move it from the attr code to the transaction code and make the attr
> code call the new function.
> 
> We rolltrans is really usefull whenever we want to use rolling
> transaction, should be generic, it isn't dependent on any part of the
> attr code anyway.
> 
So you just have some renames on calls and change where func definition is 
located.
And you've added comments.


> +/*
> + * Roll from one trans in the sequence of PERMANENT transactions to
> + * the next: permanent transactions are only flushed out when commited
> + * with XFS_TRANS_RELEASE_LOG_RES, but we still want as soon as
> + * possible to let chunks of it go to the log. So we commit the chunck
> + * we've been working on and get a new transaction to continue.
> + */

typos:
s/chunck/chunk/
s/commited/committed/

--Tim


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll, Timothy Shimmin <=