[Top] [All Lists]

TAKE 983964 - fix mount option parsing in remount

To: xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 983964 - fix mount option parsing in remount
From: tes@xxxxxxx (Tim Shimmin)
Date: Wed, 2 Jul 2008 13:42:57 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Fix mount option parsing in remount.

Remount currently happily accept any option thrown at it, although the
only filesystem specific option it actually handles is barrier/nobarrier.
And it actually doesn't handle these correctly either because it only
uses the value it parsed when we're doing a ro->rw transition.  In
addition to that there's also a bad bug in xfs_parseargs which doesn't
touch the actual option in the mount point except for a single one,
XFS_MOUNT_SMALL_INUMS and thus forced any filesystem that's every
remounted in some way to not support 64bit inodes with no way to recover
unless unmounted.

This patch changes xfs_fs_remount to use it's own linux/parser.h based
options parse instead of xfs_parseargs and reject all options except
for barrier/nobarrier and to the right thing in general.  Eventually
I'd like to have a single big option table used for mount aswell but
that can wait for a while.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Wed Jul  2 13:41:58 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  hch@xxxxxx

The following file(s) were checked into:

Modid:  xfs-linux-melb:xfs-kern:31382a
fs/xfs/linux-2.6/xfs_super.c - 1.434 - changed
        - fix mount option parsing in remount

<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 983964 - fix mount option parsing in remount, Tim Shimmin <=