xfs
[Top] [All Lists]

Re: [PATCH] Fix use after free when closing log/rt devices

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] Fix use after free when closing log/rt devices
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 2 Jul 2008 12:54:54 +1000
Cc: Mark Goodwin <markgw@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lachlan McIlroy <lachlan@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <486AE0F8.5080506@xxxxxxx>
Mail-followup-to: Timothy Shimmin <tes@xxxxxxx>, Mark Goodwin <markgw@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lachlan McIlroy <lachlan@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
References: <48647746.5010007@xxxxxxx> <20080627063219.GA25015@xxxxxxxxxxxxx> <48648B2B.3080709@xxxxxxx> <20080627090822.GA17374@xxxxxxxxxxxxx> <486AE0F8.5080506@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Wed, Jul 02, 2008 at 11:59:20AM +1000, Timothy Shimmin wrote:
> Christoph Hellwig wrote:
> > On Fri, Jun 27, 2008 at 04:39:39PM +1000, Mark Goodwin wrote:
> >> do we have any QA tests that test external log?
> > 
> > Most QA tests will use the external log if you set it up that way.  But
> > ithout slab poisoning this won't be noticed either.
> 
> I think you need:
>   USE_EXTERNAL=yes
>   SCRATCH_LOGDEV=somelogdevice
>   TEST_LOGDEV=somelogdevice
> to get the scratch and test mounts using an external log.

Yes. Typically I used to use SCRATCH_LOGDEV=/dev/ram0 so I didn't
need another block device on the machine just for an external
log on a throw-away filesystem....

> There are no explicit external log tests (logdev=) that I can see.

It should be easy to write one using files and multiple
loopback devices.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>