xfs
[Top] [All Lists]

Re: [PATCH] Give a transaction to xfs_attr_set_int

To: Niv Sardi <xaiki@xxxxxxx>, xfs@xxxxxxxxxxx, Niv Sardi <xaiki@xxxxxxxxxx>
Subject: Re: [PATCH] Give a transaction to xfs_attr_set_int
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Tue, 1 Jul 2008 11:49:46 -0400
In-reply-to: <20080629220859.GL29319@disturbed>
References: <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1214196150-5427-2-git-send-email-xaiki@xxxxxxx> <1214196150-5427-3-git-send-email-xaiki@xxxxxxx> <1214196150-5427-4-git-send-email-xaiki@xxxxxxx> <1214196150-5427-5-git-send-email-xaiki@xxxxxxx> <20080629220859.GL29319@disturbed>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Mon, Jun 30, 2008 at 08:08:59AM +1000, Dave Chinner wrote:
...
> > @@ -356,6 +381,8 @@ xfs_attr_set_int(xfs_inode_t *dp, const char *name, int 
> > namelen,
> >                     if (!error && (flags & ATTR_KERNOTIME) == 0) {
> >                             xfs_ichgtime(dp, XFS_ICHGTIME_CHG);
> >                     }
> > +                   if (tpp)
> > +                           tpp = &args.trans;
> 
> That's busted too. Can you please review all the places where you
> return transactio pointers to the caller via a function parameterrr
> for this bug as you've made in at least a couple of places.

Niv: Why not return the pointer as a return value?

Josef 'Jeff' Sipek.

-- 
Humans were created by water to transport it upward.


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] Give a transaction to xfs_attr_set_int, Josef 'Jeff' Sipek <=