| To: | Takashi Sato <t-sato@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] Add timeout feature |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 1 Jul 2008 04:10:26 -0400 |
| Cc: | akpm@xxxxxxxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, axboe@xxxxxxxxx, mtk.manpages@xxxxxxxxxxxxxx |
| In-reply-to: | <20080630212450t-sato@xxxxxxxxxxxxxxx> |
| References: | <20080630212450t-sato@xxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
I still disagree with this whole patch. There is not reason to let the freeze request timeout - an auto-unfreezing will only confuse the hell out of the caller. The only reason where the current XFS freeze call can hang and this would be theoretically useful is when the filesystem is already frozen by someone else, but this should be fixed by refusing to do the second freeze, as suggested in my comment to patch 1. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] Implement generic freeze feature, Christoph Hellwig |
|---|---|
| Next by Date: | Re: REVIEW: xfs_repair fixes for bad directories, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/3] Implement generic freeze feature, Christoph Hellwig |
| Next by Thread: | Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Alasdair G Kergon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |