xfs
[Top] [All Lists]

Re: [PATCH 0/4] XFS: replace the mount inode list with radix tree traver

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/4] XFS: replace the mount inode list with radix tree traversals V2
From: Mark Goodwin <markgw@xxxxxxx>
Date: Wed, 23 Jul 2008 12:23:36 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1216773673-3620-1-git-send-email-david@fromorbit.com>
Organization: SGI Engineering
References: <1216773673-3620-1-git-send-email-david@fromorbit.com>
Reply-to: markgw@xxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Windows/20080421)


Dave Chinner wrote:
The list of all inodes on a mount is superfluous. We can traverse
all inodes now by walking the per-AG inode radix trees without
needing a separate list. This enables us to remove a bunch of
complex list traversal code and remove another two pointers from
the xfs_inode.

sounds like a good move.

Also, by replacing the sync traversal with an ascending inode
number traversal, we will issue better inode I/O patterns for
writeback triggered by xfssyncd or unmount.

Dave, have you made any performance measurements showing this to be the case? If so, what is the improvement? Or should we just assume such traversals will be more naturally sequential and therefore more efficient?

Cheers
-- Mark


<Prev in Thread] Current Thread [Next in Thread>