xfs
[Top] [All Lists]

TAKE 983924 - take back out again QUEUE_ORDERED_NONE test in check_barri

To: xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 983924 - take back out again QUEUE_ORDERED_NONE test in check_barriers
From: tes@xxxxxxx (Tim Shimmin)
Date: Tue, 1 Jul 2008 16:01:10 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Disable queue flag test in barrier check.

md raid1 can pass down barriers, but does not set an ordered flag
on the queue, so xfs does not even attempt a barrier write, and
will never use barriers on these block devices.

Remove the flag check and just let the barrier write
test determine barrier support.

A possible risk here is that if something does not set an ordered
flag and also does not properly return an error on a barrier write...
but if it's any consolation jbd/ext3/reiserfs never test the flag,
and don't even do a test write, they just disable barriers the first
time an actual journal barrier write fails.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Date:  Tue Jul  1 15:59:48 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  sandeen@xxxxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31377a
fs/xfs/linux-2.6/xfs_super.c - 1.433 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.433&r2=text&tr2=1.432&f=h
        - disable queue flag test in barrier check


<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 983924 - take back out again QUEUE_ORDERED_NONE test in check_barriers, Tim Shimmin <=