xfs
[Top] [All Lists]

Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 27 Jun 2008 09:03:44 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20080627130310.GA4659@xxxxxxxxxxxxx>
References: <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1214196150-5427-2-git-send-email-xaiki@xxxxxxx> <1214196150-5427-3-git-send-email-xaiki@xxxxxxx> <20080626082827.GC23954@xxxxxxxxxxxxx> <ncctzff1o7e.fsf@xxxxxxx> <20080627130310.GA4659@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
But this isn't actually the patch described by the subject..

On Fri, Jun 27, 2008 at 09:03:10AM -0400, Christoph Hellwig wrote:
> Looks good except for a tiny nitpick:
> 
> > +/*
> > + * Calculate how many blocks we need for the new attribute,
> > + */
> > +int
> > +xfs_attr_calc_size(
> > +   struct xfs_inode *ip,
> > +   int             namelen,
> > +   int             valuelen,
> > +   int             *local)
> > +{
> > +   struct xfs_mount *mp = ip->i_mount;
> 
> Add another tab before the variable names so that it aligns nicely.


<Prev in Thread] Current Thread [Next in Thread>