| To: | Niv Sardi <xaiki@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 27 Jun 2008 09:03:10 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <ncctzff1o7e.fsf@xxxxxxx> |
| References: | <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1214196150-5427-2-git-send-email-xaiki@xxxxxxx> <1214196150-5427-3-git-send-email-xaiki@xxxxxxx> <20080626082827.GC23954@xxxxxxxxxxxxx> <ncctzff1o7e.fsf@xxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
Looks good except for a tiny nitpick:
> +/*
> + * Calculate how many blocks we need for the new attribute,
> + */
> +int
> +xfs_attr_calc_size(
> + struct xfs_inode *ip,
> + int namelen,
> + int valuelen,
> + int *local)
> +{
> + struct xfs_mount *mp = ip->i_mount;
Add another tab before the variable names so that it aligns nicely.
|
| Previous by Date: | [PATCH] Fix disabled XFS POSIX ACL handling, David Howells |
|---|---|
| Next by Date: | Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll, Niv Sardi |
| Next by Thread: | Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |