xfs
[Top] [All Lists]

Re: [PATCH] Move attr log alloc size calculator to another function.

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Move attr log alloc size calculator to another function.
From: Niv Sardi <xaiki@xxxxxxx>
Date: Fri, 27 Jun 2008 14:49:31 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080626082438.GB23954@xxxxxxxxxxxxx> (Christoph Hellwig's message of "Thu, 26 Jun 2008 04:24:38 -0400")
References: <1214196150-5427-1-git-send-email-xaiki@xxxxxxx> <1214196150-5427-2-git-send-email-xaiki@xxxxxxx> <20080626082438.GB23954@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (i486-pc-linux-gnu)
Attached updated patch.

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
> On Mon, Jun 23, 2008 at 02:42:27PM +1000, Niv Sardi wrote:
>> From: Niv Sardi <xaiki@xxxxxxxxxx>
>> 
>> We will need that to be able to calculate the size of log we need for
>> a specific attr (for parent pointers in create). We need the local so
>> that we can fail if we run into ENOSPC when trying to alloc blocks

Updated Comments, structs instead of typdefs
 
>> Signed-off-by: Niv Sardi <xaiki@xxxxxxx>
>> ---
>>  fs/xfs/xfs_attr.c |   78 
>> +++++++++++++++++++++++++++++++---------------------
>>  fs/xfs/xfs_attr.h |    2 +-
>>  2 files changed, 47 insertions(+), 33 deletions(-)
>> 
>> diff --git a/fs/xfs/xfs_attr.c b/fs/xfs/xfs_attr.c
>> index e58f321..0d19e90 100644
>> --- a/fs/xfs/xfs_attr.c
>> +++ b/fs/xfs/xfs_attr.c
>> @@ -185,6 +185,43 @@ xfs_attr_get(
>>  }
>>  
>>  int
>> +xfs_attr_calc_size(
>
> should be marked STATIC,

The whole idea is to be able to use it in xfs_create().




<Prev in Thread] Current Thread [Next in Thread>