[Top] [All Lists]

Re: TAKE 976035 - streamline init/exit path

To: Niv Sardi <xaiki@xxxxxxx>
Subject: Re: TAKE 976035 - streamline init/exit path
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 27 Jun 2008 09:54:41 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080625030057.973173A5D1@itchy>
Mail-followup-to: Niv Sardi <xaiki@xxxxxxx>, xfs@xxxxxxxxxxx
References: <20080625030057.973173A5D1@itchy>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
On Wed, Jun 25, 2008 at 01:00:57PM +1000, Niv Sardi wrote:
> streamline init/exit path
> Currently the xfs module init/exit code is a mess.  It's farmed out
> over a lot of function with very little error checking.  This patch
> makes sure we propagate all initialization failures properly and clean
> up after them.  Various runtime initializations are replaced with
> compile-time initializations where possible to make this easier.  The
> exit path is similarly consolidated.
> There's now split out function to create/destroy the kmem zones and
> alloc/free the trace buffers.  I've also changed the ktrace
> allocations to KM_MAYFAIL and handled errors resulting from that.
> And yes, we really should replace the XFS_*_TRACE ifdefs with a single
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Niv Sardi <xaiki@xxxxxxx>

Niv, can you now do another checkin that fixes the compilation
error when CONFIG_PROCFS=N in fs/xfs/linux-2.6/xfs_stats.h that
was reported on linux-next (i.e. fix the bug that led up to
everyone discovering the busted commit)?

BTW, your script is still busted - look at the wacky cc list
on the take message. Please be a little more careful...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>