xfs
[Top] [All Lists]

TAKE 983677 - check for invalid flags in xfs_attrlist_by_handle

To: xfs@xxxxxxxxxxx, sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 983677 - check for invalid flags in xfs_attrlist_by_handle
From: tes@xxxxxxx (Tim Shimmin)
Date: Wed, 25 Jun 2008 10:18:29 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Check for invalid flags in xfs_attrlist_by_handle.

xfs_attrlist_by_handle should only take the ATTR_ flags for the root
namespaces.  The ATTR_KERN* flags may change at anytime and expect special
preconditions that can't be guaranteed for userspace-originating
requests.  For example passing down ATTR_KERNNOVAL through
xfs_attrlist_by_handle will hit an assert in debug builds currently.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Wed Jun 25 10:17:00 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  hch@xxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31351a
fs/xfs/linux-2.6/xfs_ioctl.c - 1.166 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_ioctl.c.diff?r1=text&tr1=1.166&r2=text&tr2=1.165&f=h
        - check for invalid flags in xfs_attrlist_by_handle


<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 983677 - check for invalid flags in xfs_attrlist_by_handle, Tim Shimmin <=