xfs
[Top] [All Lists]

Re: [PATCH] check for invalid flags in xfs_attrlist_by_handle

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] check for invalid flags in xfs_attrlist_by_handle
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 20 Jun 2008 07:48:13 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <485B431F.2070905@xxxxxxx>
References: <20080531075829.GA5424@xxxxxx> <485B431F.2070905@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Fri, Jun 20, 2008 at 03:41:51PM +1000, Timothy Shimmin wrote:
> Fair enough.
> Actually, I think we only use ATTR_ROOT and ATTR_SECURE for the
> namespace flags.
> So you could probably use: XFS_ATTR_NSP_ARGS
> xfs_attr_leaf.h:#define XFS_ATTR_NSP_ARGS_MASK         (ATTR_ROOT | 
> ATTR_SECURE)
> xfs_attr_leaf.h:#define XFS_ATTR_NSP_ARGS(flags) ((flags) & 
> XFS_ATTR_NSP_ARGS_MASK)
> and something like:
> 
> if (!XFS_ATTR_NSP_ARGS(al_hreq.flags))
>          return -XFS_ERROR(EINVAL);
> 
> Though would probably then need to include the right header (xfs_attr_leaf.h) 
> for it...

Makes sense.  I'll revise the patch and send an updated version after
running it through QA.


<Prev in Thread] Current Thread [Next in Thread>