xfs
[Top] [All Lists]

Re: [PATCH] fix dir2 shortform structures on ARM old ABI

To: markgw@xxxxxxx
Subject: Re: [PATCH] fix dir2 shortform structures on ARM old ABI
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 05 Jun 2008 00:49:08 -0500
Cc: Timothy Shimmin <tes@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <48477DA3.8090602@xxxxxxx>
References: <47DB4181.7040603@xxxxxxxxxxx> <480E89B5.8070006@xxxxxxxxxxx> <481B7FD1.3030107@xxxxxxxxxxx> <20080505070847.GH155679365@xxxxxxx> <481FDCD1.2010905@xxxxxxx> <4820609C.9090306@xxxxxxxxxxx> <48477BD6.2020909@xxxxxxxxxxx> <48477DA3.8090602@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Mark Goodwin wrote:
> 
> Eric Sandeen wrote:
>> Eric Sandeen wrote:
>>> Timothy Shimmin wrote:
>>>> David Chinner wrote:
>>>>> On Fri, May 02, 2008 at 03:55:45PM -0500, Eric Sandeen wrote:
>>>>>> Eric Sandeen wrote:
>>>>>>> Eric Sandeen wrote:
>>>>>>>> This should fix the longstanding issues with xfs and old ABI
>>>>>>>> arm boxes, which lead to various asserts and xfs shutdowns,
>>>>>>>> and for which an (incorrect) patch has been floating around
>>>>>>>> for years.  (Said patch made ARM internally consistent, but
>>>>>>>> altered the normal xfs on-disk format such that it looked
>>>>>>>> corrupted on other architectures):
>>>>>>>> http://lists.arm.linux.org.uk/lurker/message/20040311.002034.5ecf21a2.html
>>>>>>> ping again...
>>>>>> ping #3...
>>>>> <sigh>
>> Guys, this is SIMPLE, SAFE, and it fixes a CORRUPTION BUG.
>> is it EVER going to get checked in?
> 
> Please take it in Tim, that nasty CORRUPTION word caught my attention :)
> 
> Cheers

heh, thanks Mark.  Even though it's only CORRUPTION ON ARM I guess the
shouting worked.  :)

Seriously though if you guys have any problems with it please let me
know but I don't want it to just get dropped.

-Eric


<Prev in Thread] Current Thread [Next in Thread>