xfs
[Top] [All Lists]

Re: [PATCH] fix mount option parsing in remount

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] fix mount option parsing in remount
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 3 Jun 2008 15:05:34 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <48453E5D.8050301@xxxxxxxxxxx>
References: <20080518153539.GA5218@xxxxxx> <48453E5D.8050301@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Tue, Jun 03, 2008 at 07:51:41AM -0500, Eric Sandeen wrote:
> Maybe expand this a little:
> 
> /*
>  * Today only the barrier/nobarrier xfs mount options are handled
>  * on remount.  This table should be expanded to cover all options,
>  * and used for the initial mount path, too.
>  */
> 
> ... I'd also like this for the mount path because for example:
> 
> mount -t xfs -o barrier=0 /dev/blah /mnt/foo
> 
> works... but does not turn off barriers.
> 
> So as a first step/example this looks ok but I'd sure like to see it
> extended soon.  Maybe when I'm bored... :)

Doh.  But yeah, mount path should be switched over soon.  I alredy
posted the patches to kill the xfs_mount_args gunk which have been on
the list for a while and happily ignored, and switching to the parser.h
helper ontop of that is quite easy.  I just want to wait a little bit
so that any problems with the previous patch are shaked out before the
new one gets added.


<Prev in Thread] Current Thread [Next in Thread>