Re: [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

But this isn't actually the patch described by the subject..

On Fri, Jun 27, 2008 at 09:03:10AM -0400, Christoph Hellwig wrote:
> Looks good except for a tiny nitpick:
> 
> > +/*
> > + * Calculate how many blocks we need for the new attribute,
> > + */
> > +int
> > +xfs_attr_calc_size(
> > +   struct xfs_inode *ip,
> > +   int             namelen,
> > +   int             valuelen,
> > +   int             *local)
> > +{
> > +   struct xfs_mount *mp = ip->i_mount;
> 
> Add another tab before the variable names so that it aligns nicely.