Re: [PATCH] Don't assert if trying to mount with blocksize

xfs

Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize

To:	Lachlan McIlroy <lachlan@xxxxxxx>
Subject:	Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 26 Jun 2008 13:03:15 +1000
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<4863056D.3080209@sgi.com>
Mail-followup-to:	Lachlan McIlroy <lachlan@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
References:	<4863056D.3080209@sgi.com>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17+20080114 (2008-01-14)

On Thu, Jun 26, 2008 at 12:56:45PM +1000, Lachlan McIlroy wrote:
> If we don't do the blocksize/PAGESIZE check before
> calling xfs_sb_validate_fsb_count() we can assert
> if we try to mount with a blocksize > pagesize.
> The assert is valid so leave it and just move the
> blocksize/pagesize check earlier.

Yes, looks like a problem. The fix looks ok.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Don't assert if trying to mount with blocksize > pagesize, Lachlan McIlroy Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize, Dave Chinner <= Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize, Christoph Hellwig

Previous by Date:	[PATCH] Don't assert if trying to mount with blocksize > pagesize, Lachlan McIlroy
Next by Date:	[PATCH] disable queue flag test in barrier check, Eric Sandeen
Previous by Thread:	[PATCH] Don't assert if trying to mount with blocksize > pagesize, Lachlan McIlroy
Next by Thread:	Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]