Re: [patch] xfsqa 078 - use rmdir to remove directories

xfs

Re: [patch] xfsqa 078 - use rmdir to remove directories

To:	David Chinner <dgc@xxxxxxx>
Subject:	Re: [patch] xfsqa 078 - use rmdir to remove directories
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 22 May 2008 09:22:05 -0400
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<20080522061120.GP173056135@xxxxxxx>
References:	<20080522061120.GP173056135@xxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17 (2007-11-01)

On Thu, May 22, 2008 at 04:11:20PM +1000, David Chinner wrote:
> 
> If test 078 fails and you try to run it again immediately, it
> will execute a 'rm -f' on a directory which will fail. This should
> be a rmdir....

Looks good.  rm -rf woul also do it, although slightly more dangerous :)

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch] xfsqa 078 - use rmdir to remove directories, David Chinner Re: [patch] xfsqa 078 - use rmdir to remove directories, Christoph Hellwig <=

Previous by Date:	[RFC PATCH 3/3] Add timeout feature, Takashi Sato
Next by Date:	Re: [patch] allow mkfs to make larger logs, Christoph Hellwig
Previous by Thread:	[patch] xfsqa 078 - use rmdir to remove directories, David Chinner
Next by Thread:	[patch] allow mkfs to make larger logs, David Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]