xfs
[Top] [All Lists]

Re: [patch] allow mkfs to make larger logs

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [patch] allow mkfs to make larger logs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 22 May 2008 09:23:33 -0400
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080522061222.GQ173056135@xxxxxxx>
References: <20080522061222.GQ173056135@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, May 22, 2008 at 04:12:22PM +1000, David Chinner wrote:
> ===================================================================
> --- xfs-cmds.orig/xfsprogs/include/xfs_fs.h   2008-05-15 16:32:52.929462025 
> +1000
> +++ xfs-cmds/xfsprogs/include/xfs_fs.h        2008-05-15 18:50:19.494520368 
> +1000
> @@ -248,10 +248,13 @@ typedef struct xfs_fsop_resblks {
>   * Minimum and maximum sizes need for growth checks
>   */
>  #define XFS_MIN_AG_BLOCKS    64
> -#define XFS_MIN_LOG_BLOCKS   512
> -#define XFS_MAX_LOG_BLOCKS   (64 * 1024)
> -#define XFS_MIN_LOG_BYTES    (256 * 1024)
> -#define XFS_MAX_LOG_BYTES    (128 * 1024 * 1024)
> +#define XFS_MIN_LOG_BLOCKS   512ULL
> +#define XFS_MAX_LOG_BLOCKS   (1024 * 1024ULL)
> +#define XFS_MIN_LOG_BYTES    (10 * 1024 * 1024ULL)
> +
> +/* keep the maximum size under 2^31 by a small amount */
> +#define XFS_MAX_LOG_BYTES \
> +     ((2 * 1024 * 1024 * 1024ULL) - XFS_MIN_LOG_BYTES)

This file is a copy for the kernel, so please update it there aswell,
once we get changes to these files in both xfs-cmds and the kernel tree
merging will become a complete nightmare.

Except for that the patch looks good to me.


<Prev in Thread] Current Thread [Next in Thread>