xfs
[Top] [All Lists]

REVIEW: Forgot to remove d_add call when taking out drop_negative_childr

To: xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx
Subject: REVIEW: Forgot to remove d_add call when taking out drop_negative_children code
From: bnaujok@xxxxxxx (Barry Naujok)
Date: Thu, 22 May 2008 10:15:15 +1000
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: nail 11.25 7/29/05
--- a/fs/xfs/linux-2.6/xfs_iops.c       2008-05-22 10:15:15.000000000 +1000
+++ b/fs/xfs/linux-2.6/xfs_iops.c       2008-05-22 10:12:29.961204467 +1000
@@ -420,7 +420,11 @@ xfs_vn_ci_lookup(
        if (unlikely(error)) {
                if (unlikely(error != ENOENT))
                        return ERR_PTR(-error);
-               d_add(dentry, NULL);
+               /*
+                * call d_add(dentry, NULL) here when d_drop_negative_children
+                * is called in xfs_vn_mknod (ie. allow negative dentries
+                * with CI filesystems).
+                */
                return NULL;
        }
 


<Prev in Thread] Current Thread [Next in Thread>
  • REVIEW: Forgot to remove d_add call when taking out drop_negative_children code, Barry Naujok <=