Re: [PATCH] streamline init/exit path

[Niv Sardi <xaiki@xxxxxxx>]

Christoph Hellwig <hch@xxxxxx> writes:

> Currently the xfs module init/exit code is a mess.  It's farmed out
> over a lot of function with very little error checking.  This patch
> merges xfs_init_zones and xfs_init into init_xfs_fs, and makes sure
> we propagate all initialization failures properly and clean up after
> them.  Various runtime initializations are replaced with compile-time
> initializations where possible to make this easier.  The exit path
> is similarly consolidated.

Looks good, appart from the fact that I don't see the point of merging
xfs_{init,destroy}_zones into xfs_{init,exit}, appart from clobbering it
and making it less readeable.

could be:
error = xfs_init_zones();
if (error)
      goto out;

and all the other error cases will end with
xfs_destroy_zones();

That would look much more like the rest of the calls in these functions.
-- 
Niv Sardi