| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: TAKE 981875 - xfs_dm_rdwr() needs to pass a vfsmount to dentry_open() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 20 May 2008 02:43:56 -0400 |
| Cc: | sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| In-reply-to: | <20080516051048.GB5035@xxxxxxxxxxxxx> |
| References: | <20080516045732.F12DC58C4C29@xxxxxxxxxxxxxxxxxxxxxxx> <20080516051048.GB5035@xxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Fri, May 16, 2008 at 01:10:48AM -0400, Christoph Hellwig wrote: > On Fri, May 16, 2008 at 02:57:32PM +1000, Lachlan McIlroy wrote: > > xfs_dm_rdwr() needs to pass a vfsmount to dentry_open() > > > > We need a vfsmount pointer in xfs_dm_rdwr() but we are not > > provided with one and there's no way to get to it. So add > > a m_vfsmount field to the xfs_mount structure and set it > > up at mount time. We can then access it through the xfs > > inode. > > Stong NACK for this crap, and double NACK for pushing this towards > mainline. No reply yet. Folks, you realize this is an instant oops if you perform dmapi operations after one fs instance has been unmounted? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] kill xfs_lock_dir_and_entry, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] always set a/c/mtime through ->setattr, Miklos Szeredi |
| Previous by Thread: | Re: TAKE 981875 - xfs_dm_rdwr() needs to pass a vfsmount to dentry_open(), Christoph Hellwig |
| Next by Thread: | Re: TAKE 981875 - xfs_dm_rdwr() needs to pass a vfsmount to dentry_open(), Niv Sardi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |