Re: [PATCH] always set a/c/mtime through ->setattr

[Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>]

Christoph,

Christoph Hellwig wrote:
> Currently touch_atime and file_update_time directly update a/c/mtime
> in the inode and just mark the inode dirty afterwards.  This is pretty
> bad for some more complex filesystems that have various different types
> of dirtying an inode and/or need to store the data in another place
> for example for a buffer to be logged.
>
> This patch changes touch_atime and file_update_time to not update the
> inode directly but rather call through ->setattr into the filessystem.
This patch would make our (UBIFS develpers') life easier, thank you!

Could we go a further and allow the file-system returning error if it
for some reasons cannot change the time? For example, the FS could
return -EIO or -ENOSPC up and VFS would have to free resources and
propagate this error to user-space. Is this possible?

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)