xfs
[Top] [All Lists]

PARTIAL TAKE 981951 - sort out opening and closing of the block devices

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: PARTIAL TAKE 981951 - sort out opening and closing of the block devices
From: dgc@xxxxxxx (David Chinner)
Date: Tue, 20 May 2008 11:24:39 +1000 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
sort out opening and closing of the block devices

Currently closing the rt/log block device is done in the wrong spot, and
far too early.  So revampt it:

 - xfs_blkdev_put moved out of xfs_free_buftarg into the caller so that
   it is done after tearing down the buftarg completely.
 - call to xfs_unmountfs_close moved from xfs_mountfs into caller so
   that it's done after tearing down the filesystem completely.
 - xfs_unmountfs_close is renamed to xfs_close_devices and made static
   in xfs_super.c
 - opening of the block devices is split into a helper xfs_open_devices
   that is symetric in use to xfs_close_devices
 - xfs_unmountfs can now lose struct cred
 - error handling around device opening sanitized in xfs_fs_fill_super


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Tue May 20 11:24:15 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31193a
fs/xfs/xfs_mount.h - 1.267 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.h.diff?r1=text&tr1=1.267&r2=text&tr2=1.266&f=h
        - sort out opening and closing of the block devices

fs/xfs/xfs_mount.c - 1.435 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=text&tr1=1.435&r2=text&tr2=1.434&f=h
        - sort out opening and closing of the block devices

fs/xfs/linux-2.6/xfs_super.h - 1.78 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.h.diff?r1=text&tr1=1.78&r2=text&tr2=1.77&f=h
        - sort out opening and closing of the block devices

fs/xfs/linux-2.6/xfs_super.c - 1.421 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.421&r2=text&tr2=1.420&f=h
        - sort out opening and closing of the block devices

fs/xfs/linux-2.6/xfs_buf.h - 1.126 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.h.diff?r1=text&tr1=1.126&r2=text&tr2=1.125&f=h
        - sort out opening and closing of the block devices

fs/xfs/linux-2.6/xfs_buf.c - 1.257 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.c.diff?r1=text&tr1=1.257&r2=text&tr2=1.256&f=h
        - sort out opening and closing of the block devices



<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 981951 - sort out opening and closing of the block devices, David Chinner <=