xfs
[Top] [All Lists]

Re: Regression- XFS won't mount on partitioned md array

To: David Greaves <david@xxxxxxxxxxxx>
Subject: Re: Regression- XFS won't mount on partitioned md array
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 18 May 2008 00:23:24 -0500
Cc: David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, "'linux-kernel@xxxxxxxxxxxxxxx'" <linux-kernel@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <482F67D9.70400@xxxxxxxxxxx>
References: <482DC043.5000307@xxxxxxxxxxxx> <482DD981.5070004@xxxxxxxxxxx> <482EEFDA.50101@xxxxxxxxxxxx> <482EF6A7.2020909@xxxxxxxxxxx> <482F67D9.70400@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
>> I'll see if I have a little time today to track down the problem.
> 
> 
> Does this patch fix it for you?  Does for me though I can't yet explain
> why ;)
> 
> http://www.linux.sgi.com/archives/xfs/2008-05/msg00190.html
> 
> -Eric

So what's happening is that xfs is trying to read a page-sized IO from
the last sector of the log... which goes off the end of the device.
This looks like another regression introduced by
a9759f2de38a3443d5107bddde03b4f3f550060e, but fixed by Christoph's patch
in the URL above, which should be headed towards -stable.

(aside: it seems that this breaks any external log setup where the log
consists of the entire device... but I'd have expected the xfsqa suite
to catch this...?)

The patch avoids the problem by looking for some extra locking but it
seems to me that the root cause is that the buffer being read at this
point doesn't have it's b_offset, the offset in it's page, set.  Might
be another little buglet but harmless it seems.

-Eric


<Prev in Thread] Current Thread [Next in Thread>