| To: | xfs-dev <xfs-dev@xxxxxxx> |
|---|---|
| Subject: | [PATCH] update check on valid sb fields being modified on mount |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Fri, 16 May 2008 23:15:48 +1000 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
Recent changes to update the version number during mount
(attr2 stuff) failed to change the assert that checked for
calid flags being changed on mount. Clearly this path hasn't
been exercised by the test code....
Signed-off-by: Dave Chinner <dgc@xxxxxxx>
---
fs/xfs/xfs_mount.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: 2.6.x-xfs-new/fs/xfs/xfs_mount.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/xfs_mount.c 2008-05-16 23:08:18.000000000
+1000
+++ 2.6.x-xfs-new/fs/xfs/xfs_mount.c 2008-05-16 23:10:00.224848630 +1000
@@ -1887,7 +1887,8 @@ xfs_mount_log_sb(
int error;
ASSERT(fields & (XFS_SB_UNIT | XFS_SB_WIDTH | XFS_SB_UUID |
- XFS_SB_FEATURES2 | XFS_SB_BAD_FEATURES2));
+ XFS_SB_FEATURES2 | XFS_SB_BAD_FEATURES2 |
+ XFS_SB_VERSIONNUM));
tp = xfs_trans_alloc(mp, XFS_TRANS_SB_UNIT);
error = xfs_trans_reserve(tp, 0, mp->m_sb.sb_sectsize + 128, 0, 0,
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] XFS tuning on software RAID5 partitionable array; error in xfsprogs 2.9.8, Andi Kleen |
|---|---|
| Next by Date: | Re: [PATCH] update check on valid sb fields being modified on mount, Eric Sandeen |
| Previous by Thread: | Re: [PATCH] XFS tuning on software RAID5 partitionable array; error in xfsprogs 2.9.8, Hubert Verstraete |
| Next by Thread: | Re: [PATCH] update check on valid sb fields being modified on mount, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |