xfs
[Top] [All Lists]

Re: [PATCH] don't run test 167 if killall is not installed

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] don't run test 167 if killall is not installed
From: David Chinner <dgc@xxxxxxx>
Date: Thu, 15 May 2008 17:36:05 +1000
Cc: Tim Shimmin <tes@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20080515071338.GA26247@xxxxxx>
References: <20080515053918.GA16530@xxxxxx> <482BDAC1.7070407@xxxxxxx> <20080515071338.GA26247@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Thu, May 15, 2008 at 09:13:38AM +0200, Christoph Hellwig wrote:
> On Thu, May 15, 2008 at 04:40:01PM +1000, Tim Shimmin wrote:
> > Looks reasonable.
> > 
> > However:
> > 
> > * could use set_prog_path like we do in common.config.
> > 
> > * I wonder if one could use "kill -$pgid" on the process group
> > for fsstress instead of killall (I've never tried it :).
> 
> Dave already commited the original version, but I'll send an update
> to use set_prog_path later today.

Sorry, didn't see that Tim replied as well. set_prog_path is fine
by me too, but stopping every test from running because killall is
not present is a bit of overkill, isn't it?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>